openrs2

Commit Graph

Author	SHA1	Message	Date
Graham	8a3b1dff73	Fix off-by-one error in JS5 response buffer capacity calculation In some cases the capacity would be one byte greater than necessary. I've added a comment explaining why the calculation works and a unit test that ensures it is calculated correctly for all lengths between 1 and 511*3+1 bytes. Signed-off-by: Graham <gpe@openrs2.org>	3 years ago
Graham	55d72dacbe	Pass StreamCipher to PacketCodecs A small number of packets have encrypted payloads. Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	cdc1edbb1d	Use more realistic test data in the JAGGRAB test Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	b37e4d0d0b	Use alternatives for most methods deprecated in Kotlin 1.5 Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	7d041e6e22	Replace readAllBytes() with readBytes() It's more concise and I suspect Kotlin's implementation is better than Java's, as it seems to take available() into account. Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	359891c01e	Convert all test objects to classes This is required for IDEA to display the run test icon in the gutter. Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	30828308b2	Replace assertThrows with assertFailsWith Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	9ddce82df4	Format code This new indentation style for nested calls is annoying, I need to see if it can be turned off somehow... Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	7b9964461f	Fix off-by-one erorr in the JS5 codecs Excluding the 0xFF trailers, the first block is actually 512 bytes, and the remaining blocks are all 511 bytes. I had mistakenly written the code and tests on the basis of all blocks being 511 bytes. The Js5ResponseDecoder now works with OSRS. Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	96ea95394c	Add JAGGRAB request codec Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	95d6583dfe	Add initial implementation of the RS framing layer I have spent a while thinking about the best way to implement this, especially after I discovered that OSRS treats the packets sent during the handshake stage as normal packets (see share/doc/protocol/login.md for a longer explanation). I have settled on a design where the same Rs2Decoder and Rs2Encoder instances, which deal with decoding packet opcodes and lengths, will remain the same for the entire connection - unless it switches into a mode where a completely different framing scheme is used, such as JAGGRAB and JS5. Rs2Decoder and Rs2Encoder both support optional opcode encryption. The initial cipher is set to NopStreamCipher. It will be set to an IsaacRandom instance during the login process. As the scrambled opcodes used in-game overlap with the opcodes used during the login process, a class called Protocol is used to represent a set of opcodes that can be used in a particular state. The protocol can be changed at any time. Rs2Decoder sets isSingleDecode to true initially to help do this safely, but once in the final in-game state this can be disabled for performance. Unlike previous servers, like Apollo and ScapeEmulator, intermediate frame objects are not used. Rs2Decoder and Rs2Encoder call PacketCodec to directly translate an inbound ByteBuf into a POJO, or an outbound POJO into a ByteBuf. This saves a memory allocation per packet. PacketCodec implementations must provide both an encode() and a decode() method for every packet. This will ensure the library is usable as both a client and server, allowing the development of tools, such as a JS5 client, a game server stress-tester or even a proxy server for inspecting the flow of packets. PacketCodec implementations may optionally override getLength() to return their exact length, to optimise the size of the ByteBuf passed to the decode() method. (It is not necessary to override getLength() for fixed packets, as the size is already known.) The 256-element packet length array is automatically generated by the Protocol class based on the length attribute of the PacketCodec objects passed to it. This is less error-prone than populating the array manually. However, it does mean stub implementations of every packet packet will need to be provided during development - all lengths must be known in advance to ensure the client and server remain in sync. For the moment, it is legal to throw NotImplementError from a decode() method. Rs2Decoder catches this exception, prints a warning and then proceed to the next packet. Once all packets have been implemented, this code may be removed. Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	bd6cdb5530	Convert sharable ChannelHandlers to objects where possible Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	e1404a1f7f	Add missing release() call Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	e08f355e6f	Use default allocator in testDecodeFragmented Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	76977303b2	Add shorthand methods for creating ByteBufs from ByteArrays and Strings Signed-off-by: Graham <gpe@openrs2.org>	4 years ago
Graham	5036eb3da8	Add JS5 remote protocol implementation Signed-off-by: Graham <gpe@openrs2.org>	4 years ago

16 Commits (8a3b1dff73e52bd30f3edc635b7dd1d0c7ae82c9)