IDEA-130478 (optimization of 6fcac6a5: less short-lived objects)

master
Roman Shevchenko 10 years ago
parent 4638144fad
commit 5349ad435b
  1. 28
      src/org/jetbrains/java/decompiler/util/InterpreterUtil.java

@ -62,29 +62,27 @@ public class InterpreterUtil {
} }
public static byte[] getBytes(ZipFile archive, ZipEntry entry) throws IOException { public static byte[] getBytes(ZipFile archive, ZipEntry entry) throws IOException {
return readAndClose(archive.getInputStream(entry), entry.getSize()); return readAndClose(archive.getInputStream(entry), (int)entry.getSize());
} }
public static byte[] getBytes(File file) throws IOException { public static byte[] getBytes(File file) throws IOException {
return readAndClose(new FileInputStream(file), file.length()); return readAndClose(new FileInputStream(file), (int)file.length());
} }
private static byte[] readAndClose(InputStream stream, long length) throws IOException { private static byte[] readAndClose(InputStream stream, int length) throws IOException {
try {
byte[] bytes = new byte[(int) length];
DataInputStream dataStream = new DataInputStream(stream);
try { try {
dataStream.readFully(bytes); byte[] bytes = new byte[length];
} catch (EOFException ex) { int n = 0, off = 0;
throw new IOException("premature end of stream", ex); while (n < length) {
} finally { int count = stream.read(bytes, off + n, length - n);
dataStream.close(); if (count < 0) {
throw new IOException("premature end of stream");
}
n += count;
} }
return bytes; return bytes;
} finally { }
finally {
stream.close(); stream.close();
} }
} }

Loading…
Cancel
Save