openrs2

Commit Graph

Author	SHA1	Message	Date
Graham	3fe7bdcedc	Optimise CloseableInjector We now avoid provisioning if the binding is not AutoCloseable.	2 years ago
Graham	c5bd044574	Add CloseableInjector I'm going to try to minimise use of this (as per https://github.com/google/guice/wiki/Avoid-Injecting-Closable-Resources). For example, I'm going to inject a pooling DataSource rather than Connection objects, as per the advice at the end of the page. However, HikariCP's DataSource implementation is itself Closeable. Signed-off-by: Graham <gpe@openrs2.org>	3 years ago

Author

SHA1

Message

Date

Graham

3fe7bdcedc

Optimise CloseableInjector

We now avoid provisioning if the binding is not AutoCloseable.

2 years ago

Graham

c5bd044574

Add CloseableInjector

I'm going to try to minimise use of this (as per
https://github.com/google/guice/wiki/Avoid-Injecting-Closable-Resources).
For example, I'm going to inject a pooling DataSource rather than
Connection objects, as per the advice at the end of the page. However,
HikariCP's DataSource implementation is itself Closeable.

Signed-off-by: Graham <gpe@openrs2.org>

3 years ago

2 Commits (3fe7bdcedcf38018abf1f4bc189b5297a082700e)