openrs2
/
openrs2
3
1
Fork 3
Code Issues 66 Pull Requests Releases Activity
Labels Milestones
New Issue

Create CliktCommands with DI #120

Open
opened 4 years ago by gpe · 3 comments
gpe commented 4 years ago
Owner

This would allow us to push the Guice injector code back to the main() method in all cases, which is really the only place it should be.

This would allow us to push the Guice injector code back to the `main()` method in all cases, which is really the only place it should be.
gpe added the
improvement
 label 4 years ago
gpe commented 4 years ago
Poster
Owner

That said, I think it would mean that we'd create parts of the object graph that we don't need unless we were careful about using lazy injection - at least in the all subproject?

That said, I think it would mean that we'd create parts of the object graph that we don't need unless we were careful about using lazy injection - at least in the `all` subproject?
gpe commented 4 years ago
Poster
Owner

Alternatively, the CliktCommands could be converted to objects.

Alternatively, the CliktCommands could be converted to objects.
Tyluur commented 3 years ago

The usage for this would be runtime arguments?

The usage for this would be runtime arguments?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
bzip2
master
Labels
Apply labels
Clear labels
archive
Related to the archiving service asm
Related to the ASM utility module buffer
Related to the buffer library bug
A bug build
Related to the build infrastructure cache
Related to the cache library compression
Related to the compression module crypto
Related to the cryptography module deobfuscator
Related to deobfuscation (at both the bytecode- and AST-level) or decompilation docs
Related to the documentation stored in the repository feature
A new feature improvement
An improvement to an existing feature, such as refactoring, documenting or adding tests patcher
Related to client patching protocol
Related to the protocol module research
Requires further research before progress can be made util
Related to the common utility module or the YAML module
No Label archive asm buffer bug build cache compression crypto deobfuscator docs feature improvement patcher protocol research util
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openrs2/openrs2#120
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes