openrs2
/
openrs2
5
1
Fork 3
Code Issues 245 Pull Requests Releases Activity
Labels Milestones
New Issue

GL transformer converts glTexImage2D level argument to a constant #126

Closed
opened 4 years ago by gpe · 2 comments
gpe commented 4 years ago
Owner

e.g. level = 0 is translated to GL_POINTS. This doesn't make sense.

e.g. level = 0 is translated to GL_POINTS. This doesn't make sense.
gpe added the
deobfuscator
bug
 labels 4 years ago
Tyluur commented 4 years ago

I have a few questions:

  1. What should it be translated to?
  2. Why is it translating to GL_POINTS?
  3. Which function is responsible for the conversion?
I have a few questions: 1. What should it be translated to? 2. Why is it translating to GL_POINTS? 3. Which function is responsible for the conversion?
gpe commented 4 years ago
Poster
Owner
  1. In this particular case, it should just be a literal 0 and shouldn't be replaced by a GL_ constant.
  2. I assume there's a bug in our code for processing the GL registry that makes us thing the level argument has a type it doesn't actually have.
  3. https://git.openrs2.org/openrs2/openrs2/src/branch/master/deob-ast/src/main/kotlin/org/openrs2/deob/ast/transform/GlTransformer.kt, https://git.openrs2.org/openrs2/openrs2/src/branch/master/deob-ast/src/main/kotlin/org/openrs2/deob/ast/gl/GlRegistry.kt, https://git.openrs2.org/openrs2/openrs2/src/branch/master/share/deob/gl.xml
1. In this particular case, it should just be a literal `0` and shouldn't be replaced by a `GL_` constant. 2. I assume there's a bug in our code for processing the GL registry that makes us thing the `level` argument has a type it doesn't actually have. 3. https://git.openrs2.org/openrs2/openrs2/src/branch/master/deob-ast/src/main/kotlin/org/openrs2/deob/ast/transform/GlTransformer.kt, https://git.openrs2.org/openrs2/openrs2/src/branch/master/deob-ast/src/main/kotlin/org/openrs2/deob/ast/gl/GlRegistry.kt, https://git.openrs2.org/openrs2/openrs2/src/branch/master/share/deob/gl.xml
gpe closed this issue 4 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
bzip2
master
Labels
Apply labels
Clear labels
archive
Related to the archiving service asm
Related to the ASM utility module buffer
Related to the buffer library bug
A bug build
Related to the build infrastructure cache
Related to the cache library compression
Related to the compression module crypto
Related to the cryptography module deobfuscator
Related to deobfuscation (at both the bytecode- and AST-level) or decompilation docs
Related to the documentation stored in the repository feature
A new feature improvement
An improvement to an existing feature, such as refactoring, documenting or adding tests patcher
Related to client patching protocol
Related to the protocol module research
Requires further research before progress can be made util
Related to the common utility module or the YAML module
No Label archive asm buffer bug build cache compression crypto deobfuscator docs feature improvement patcher protocol research util
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openrs2/openrs2#126
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes