openrs2
/
openrs2
3
1
Fork 3
Code Issues 66 Pull Requests Releases Activity
Labels Milestones
New Issue

Investigate ForgeFlower patches #91

Open
opened 4 years ago by gpe · 4 comments
gpe commented 4 years ago
Owner

https://github.com/MinecraftForge/ForgeFlower/tree/master/FernFlower-Patches

Some of these are really good - e.g. the try/finally one fixed the problem we had in the client.

There are probably many we want to incorporate into our own fork - perhaps most or even all of them?

https://github.com/MinecraftForge/ForgeFlower/tree/master/FernFlower-Patches Some of these are really good - e.g. the try/finally one fixed the problem we had in the client. There are probably many we want to incorporate into our own fork - perhaps most or even all of them?
gpe added the
research
deobfuscator
 labels 4 years ago
gpe commented 4 years ago
Poster
Owner

https://github.com/MinecraftForge/ForgeFlower/blob/master/FernFlower-Patches/0033-Do-not-hide-empty-constructors-that-change-access-le.patch would be nice, but it doesn't apply cleanly.

https://github.com/MinecraftForge/ForgeFlower/blob/master/FernFlower-Patches/0033-Do-not-hide-empty-constructors-that-change-access-le.patch would be nice, but it doesn't apply cleanly.
gpe commented 4 years ago
Poster
Owner

Not part of Forgeflower, but would be useful: a9d4df1567

or is that best done in the AST transformer?

Not part of Forgeflower, but would be useful: https://github.com/Velocity-/fernflower-improved/commit/a9d4df156783edc3ad8375f3e9d0ebfd3f1e4e45 or is that best done in the AST transformer?
gpe commented 4 years ago
Poster
Owner

would be nice, but it doesn't apply cleanly.

that's because our newer version of Fernflower already has an equivalent change!

> would be nice, but it doesn't apply cleanly. that's because our newer version of Fernflower already has an equivalent change!
gpe commented 4 years ago
Poster
Owner

https://github.com/MinecraftForge/ForgeFlower/blob/master/FernFlower-Patches/0034-Revert-change-to-FieldExprent-getExprentUse.patch is another one to try

https://github.com/MinecraftForge/ForgeFlower/blob/master/FernFlower-Patches/0034-Revert-change-to-FieldExprent-getExprentUse.patch is another one to try
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
bzip2
master
Labels
Apply labels
Clear labels
archive
Related to the archiving service asm
Related to the ASM utility module buffer
Related to the buffer library bug
A bug build
Related to the build infrastructure cache
Related to the cache library compression
Related to the compression module crypto
Related to the cryptography module deobfuscator
Related to deobfuscation (at both the bytecode- and AST-level) or decompilation docs
Related to the documentation stored in the repository feature
A new feature improvement
An improvement to an existing feature, such as refactoring, documenting or adding tests patcher
Related to client patching protocol
Related to the protocol module research
Requires further research before progress can be made util
Related to the common utility module or the YAML module
No Label archive asm buffer bug build cache compression crypto deobfuscator docs feature improvement patcher protocol research util
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openrs2/openrs2#91
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes