Always iterate through the JavaParser tree in POSTORDER

I think this is less prone to errors than the default order.

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/BitMaskTransformer.java

@@ -1,10 +1,12 @@
 package dev.openrs2.deob.ast.transform;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.BinaryExpr;
 import com.github.javaparser.ast.expr.IntegerLiteralExpr;
 import com.google.common.collect.ImmutableSet;
 import dev.openrs2.deob.ast.util.ExprUtils;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class BitMaskTransformer extends Transformer {
 	private static final ImmutableSet<BinaryExpr.Operator> SHIFT_OPS = ImmutableSet.of(
@@ -20,7 +22,7 @@ public final class BitMaskTransformer extends Transformer {
 
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(BinaryExpr.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, BinaryExpr.class, expr -> {
 			var shiftOp = expr.getOperator();
 			var left = expr.getLeft();
 			var shamtExpr = expr.getRight();

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/ComplementTransformer.java

@@ -3,11 +3,13 @@ package dev.openrs2.deob.ast.transform;
 import java.util.Optional;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.BinaryExpr;
 import com.github.javaparser.ast.expr.Expression;
 import com.github.javaparser.ast.expr.IntegerLiteralExpr;
 import com.github.javaparser.ast.expr.UnaryExpr;
 import dev.openrs2.deob.ast.util.ExprUtils;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class ComplementTransformer extends Transformer {
 	private static boolean isComplement(Expression expr) {
@@ -50,7 +52,7 @@ public final class ComplementTransformer extends Transformer {
 
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(BinaryExpr.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, BinaryExpr.class, expr -> {
 			complement(expr.getOperator()).ifPresent(op -> {
 				var left = expr.getLeft();
 				var right = expr.getRight();

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/EncloseTransformer.java

@@ -3,8 +3,10 @@ package dev.openrs2.deob.ast.transform;
 import java.util.Optional;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.EnclosedExpr;
 import com.github.javaparser.ast.expr.Expression;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class EncloseTransformer extends Transformer {
 	private enum Associativity {
@@ -143,7 +145,7 @@ public final class EncloseTransformer extends Transformer {
 
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(Expression.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, Expression.class, expr -> {
 			if (expr.isArrayAccessExpr()) {
 				var accessExpr = expr.asArrayAccessExpr();
 				encloseLeft(expr, accessExpr.getName());

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/IfElseTransformer.java

@@ -37,7 +37,7 @@ public final class IfElseTransformer extends Transformer {
 
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(IfStmt.class).forEach(stmt -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, IfStmt.class, stmt -> {
 			stmt.getElseStmt().ifPresent(elseStmt -> {
 				var condition = stmt.getCondition();
 				var thenStmt = stmt.getThenStmt();

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/NegativeLiteralTransformer.java

@@ -1,13 +1,15 @@
 package dev.openrs2.deob.ast.transform;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.UnaryExpr;
 import dev.openrs2.deob.ast.util.ExprUtils;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class NegativeLiteralTransformer extends Transformer {
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(UnaryExpr.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, UnaryExpr.class, expr -> {
 			var operand = expr.getExpression();
 			if (!ExprUtils.isIntegerOrLongLiteral(operand)) {
 				return;

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/TernaryTransformer.java

@@ -1,13 +1,15 @@
 package dev.openrs2.deob.ast.transform;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.ConditionalExpr;
 import dev.openrs2.deob.ast.util.ExprUtils;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class TernaryTransformer extends Transformer {
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(ConditionalExpr.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, ConditionalExpr.class, expr -> {
 			var condition = expr.getCondition();
 			var notCondition = ExprUtils.not(condition);
 			if (ExprUtils.countNots(notCondition) >= ExprUtils.countNots(condition)) {

deob-ast/src/main/java/dev/openrs2/deob/ast/transform/UnencloseTransformer.java

@@ -1,12 +1,14 @@
 package dev.openrs2.deob.ast.transform;
 
 import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.expr.EnclosedExpr;
+import dev.openrs2.deob.ast.util.NodeUtils;
 
 public final class UnencloseTransformer extends Transformer {
 	@Override
 	public void transform(CompilationUnit unit) {
-		unit.findAll(EnclosedExpr.class).forEach(expr -> {
+		NodeUtils.walk(unit, Node.TreeTraversal.POSTORDER, EnclosedExpr.class, expr -> {
 			expr.replace(expr.getInner().clone());
 		});
 	}