Convert hasCode() to a property

Signed-off-by: Graham <gpe@openrs2.dev>

asm/src/main/java/dev/openrs2/asm/ClassNodeRemapper.kt

@@ -31,7 +31,7 @@ fun ClassNode.remap(remapper: Remapper) {
         method.signature = remapper.mapSignature(method.signature, false)
         method.exceptions = method.exceptions.map(remapper::mapType)
 
-        if (method.hasCode()) {
+        if (method.hasCode) {
             ClassForNameUtils.remap(remapper, method)
 
             for (insn in method.instructions) {

asm/src/main/java/dev/openrs2/asm/MethodNodeUtils.kt

@@ -123,9 +123,8 @@ fun MethodNode.removeDeadCode(owner: String) {
     } while (changed)
 }
 
-fun MethodNode.hasCode(): Boolean {
+val MethodNode.hasCode
-    return access and (Opcodes.ACC_NATIVE or Opcodes.ACC_ABSTRACT) == 0
+    get() = access and (Opcodes.ACC_NATIVE or Opcodes.ACC_ABSTRACT) == 0
-}
 
 fun MethodNode.copy(): MethodNode {
     val copy = MethodNode(

asm/src/main/java/dev/openrs2/asm/transform/Transformer.kt

@@ -26,7 +26,7 @@ abstract class Transformer {
                     for (method in clazz.methods) {
                         changed = changed or preTransformMethod(classPath, library, clazz, method)
 
-                        if (method.hasCode()) {
+                        if (method.hasCode) {
                             changed = changed or transformCode(classPath, library, clazz, method)
                         }
 

bundler/src/main/java/dev/openrs2/bundler/transform/BufferSizeTransformer.kt

@@ -26,7 +26,7 @@ class BufferSizeTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (!method.hasCode()) {
+                    if (!method.hasCode) {
                         continue
                     }
 

deob/src/main/java/dev/openrs2/deob/transform/BitwiseOpTransformer.kt

@@ -27,7 +27,7 @@ class BitwiseOpTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (!method.hasCode()) {
+                    if (!method.hasCode) {
                         continue
                     }
 

deob/src/main/java/dev/openrs2/deob/transform/ConstantArgTransformer.kt

@@ -99,7 +99,7 @@ class ConstantArgTransformer : Transformer() {
         // find ClassNode/MethodNode
         val owner = classPath.getClassNode(ref.owner) ?: return
         val originalMethod = owner.methods.singleOrNull { it.name == ref.name && it.desc == ref.desc } ?: return
-        if (!originalMethod.hasCode()) {
+        if (!originalMethod.hasCode) {
             return
         }
 

deob/src/main/java/dev/openrs2/deob/transform/CounterTransformer.kt

@@ -26,7 +26,7 @@ class CounterTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (method.hasCode()) {
+                    if (method.hasCode) {
                         findCounters(method, references, resets, increments)
                     }
                 }

deob/src/main/java/dev/openrs2/deob/transform/OpaquePredicateTransformer.kt

@@ -30,7 +30,7 @@ class OpaquePredicateTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (method.hasCode()) {
+                    if (method.hasCode) {
                         findFlowObstructors(library, method)
                     }
                 }

deob/src/main/java/dev/openrs2/deob/transform/ResetTransformer.kt

@@ -28,7 +28,7 @@ class ResetTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (!method.hasCode()) {
+                    if (!method.hasCode) {
                         continue
                     }
 

deob/src/main/java/dev/openrs2/deob/transform/UnusedArgTransformer.kt

@@ -36,7 +36,7 @@ class UnusedArgTransformer : Transformer() {
         for (library in classPath.libraries) {
             for (clazz in library) {
                 for (method in clazz.methods) {
-                    if (method.hasCode()) {
+                    if (method.hasCode) {
                         populateRetainedArgs(classPath, clazz, method)
                     }
                 }
@@ -94,7 +94,7 @@ class UnusedArgTransformer : Transformer() {
         method: MethodNode
     ): Boolean {
         // delete unused int args from call sites
-        if (!method.hasCode()) {
+        if (!method.hasCode) {
             return false
         }