Improve robustness of reference counting in JaggrabChannelHandler

Signed-off-by: Graham <gpe@openrs2.org>
pull/132/head
Graham 3 years ago
parent 620808cb97
commit 03fc499566
  1. 14
      game/src/main/kotlin/org/openrs2/game/net/jaggrab/JaggrabChannelHandler.kt

@ -4,6 +4,7 @@ import io.netty.channel.ChannelFutureListener
import io.netty.channel.ChannelHandler import io.netty.channel.ChannelHandler
import io.netty.channel.ChannelHandlerContext import io.netty.channel.ChannelHandlerContext
import io.netty.channel.SimpleChannelInboundHandler import io.netty.channel.SimpleChannelInboundHandler
import org.openrs2.buffer.use
import org.openrs2.game.net.FileProvider import org.openrs2.game.net.FileProvider
import org.openrs2.protocol.jaggrab.JaggrabRequest import org.openrs2.protocol.jaggrab.JaggrabRequest
import javax.inject.Inject import javax.inject.Inject
@ -19,13 +20,14 @@ public class JaggrabChannelHandler @Inject constructor(
} }
override fun channelRead0(ctx: ChannelHandlerContext, msg: JaggrabRequest) { override fun channelRead0(ctx: ChannelHandlerContext, msg: JaggrabRequest) {
val file = fileProvider.get(msg.path) fileProvider.get(msg.path).use { file ->
if (file == null) { if (file == null) {
ctx.close() ctx.close()
return return
} }
ctx.write(file).addListener(ChannelFutureListener.CLOSE) ctx.write(file.retain()).addListener(ChannelFutureListener.CLOSE)
}
} }
override fun channelReadComplete(ctx: ChannelHandlerContext) { override fun channelReadComplete(ctx: ChannelHandlerContext) {

Loading…
Cancel
Save