openrs2
/
openrs2
3
1
Fork 3
Code Issues 65 Pull Requests Releases Activity
Labels Milestones

Only run NewInstanceTransformer on Class references #109

Closed
Desetude wants to merge 1 commits from Desetude:fix/newinstance into master
Conversation 1 Commits 1 Files Changed 3
Desetude commented 4 years ago

Fixes a problem (in a 569 client) where

Constructor var0 = clazz.getDeclaredConstructor();
return var0.newInstance();

was transformed to

Constructor var0 = clazz.getDeclaredConstructor();
return var0.getDeclaredConstructor().newInstance();

This required patching javaparser to be able to resolve types in the client properly, and these changes are now upstream: https://github.com/javaparser/javaparser/pull/2675https://github.com/javaparser/javaparser/pull/2697 (the diff in that PR is quite large since the a javaparser maintainer refactored some related code in the branch).

Fixes a problem (in a 569 client) where ``` Constructor var0 = clazz.getDeclaredConstructor(); return var0.newInstance(); ``` was transformed to ``` Constructor var0 = clazz.getDeclaredConstructor(); return var0.getDeclaredConstructor().newInstance(); ``` This required patching javaparser to be able to resolve types in the client properly, and these changes are now upstream: https://github.com/javaparser/javaparser/pull/2675~~https://github.com/javaparser/javaparser/pull/2697~~ (the diff in that PR is quite large since the a javaparser maintainer refactored some related code in the branch).
gpe commented 4 years ago
Owner

cherry-picked

cherry-picked
gpe closed this pull request 4 years ago
Desetude deleted branch fix/newinstance 4 years ago
All checks were successful
continuous-integration/drone/pr Build is passing
Details
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
archive
Related to the archiving service asm
Related to the ASM utility module buffer
Related to the buffer library bug
A bug build
Related to the build infrastructure cache
Related to the cache library compression
Related to the compression module crypto
Related to the cryptography module deobfuscator
Related to deobfuscation (at both the bytecode- and AST-level) or decompilation docs
Related to the documentation stored in the repository feature
A new feature improvement
An improvement to an existing feature, such as refactoring, documenting or adding tests patcher
Related to client patching protocol
Related to the protocol module research
Requires further research before progress can be made util
Related to the common utility module or the YAML module
No Label archive asm buffer bug build cache compression crypto deobfuscator docs feature improvement patcher protocol research util
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openrs2/openrs2#109
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Desetude:fix/newinstance'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes